Revert visibility change to HTMLForm $typeMappings
authorS Page <spage@wikimedia.org>
Sat, 12 Oct 2013 08:10:24 +0000 (01:10 -0700)
committerS Page <spage@wikimedia.org>
Sat, 12 Oct 2013 08:10:24 +0000 (01:10 -0700)
commitf5980507cb19bb66b40ad508196b61a7c05b2bfa
tree9389e5d940c04d07fe1109f640fa29839b928661
parent8b6be1c1ab951a71d54b950db5739625df909c23
Revert visibility change to HTMLForm $typeMappings

Change Id5668141835e22e3e1b043109e50d73ccd6b1229 changed the visibility
of static $typeMappings to private.  It turns out this breaks
http://www.blue-spice.org/ who want to add their own HTMLForm types and
have no way to extend or override this except by changing it.  So set it
to public static.

As https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP says,
"It's generally a good idea to avoid visibility changes unless you're
making changes to the function which would break old uses of it anyway."
That trumps PHP CodeSniffer warnings.

Change-Id: Ife82596e96a4650b977422aae6b32f24a392d5fb
includes/HTMLForm.php