resourceloader: Remove support for `addSource(id, url)`
authorTimo Tijhof <krinklemail@gmail.com>
Mon, 3 Sep 2018 23:17:11 +0000 (00:17 +0100)
committerTimo Tijhof <krinklemail@gmail.com>
Sat, 8 Sep 2018 21:45:03 +0000 (22:45 +0100)
commitf3641c0a9cf9dbf21e791e391a14a3063d95cff1
tree5b2e83d792feeac5ac1372c2f7bf24172c0de875
parente2ad234c51030384ca5acccaef83ee3f57606b37
resourceloader: Remove support for `addSource(id, url)`

The PHP interface still supports it without deprecation, but there
is no need for the client to support it given it is only ever called
from the startup module, which always passes it an object.

Follows-up 6815e355753c, which did the same for `state(key, val)`.

Also simplify the implementation to avoid extra calls and optimise
for the only signature.

Mark the method as @private, and change the existing use of
@protected to @private (doesn't really make sense in JavaScript).

Change-Id: I24786f90bcfb256b2e7c37f7760bba1a5e399443
RELEASE-NOTES-1.32
includes/resourceloader/ResourceLoader.php
resources/src/startup/mediawiki.js
tests/phpunit/includes/resourceloader/ResourceLoaderTest.php
tests/qunit/suites/resources/mediawiki/mediawiki.loader.test.js