Don't globally disable PHPCS's prohibition of assert()
authorKunal Mehta <legoktm@member.fsf.org>
Mon, 7 May 2018 08:09:19 +0000 (01:09 -0700)
committerUmherirrender <umherirrender_de.wp@web.de>
Mon, 7 May 2018 17:15:16 +0000 (17:15 +0000)
commitf093fb419243e327d2f685823a75a6634c18b279
tree5ec53f6df33dfebeef329526e777596d86a61863
parent43bfe76d46ddcd1a42bb55a73321aaaa6bee8a99
Don't globally disable PHPCS's prohibition of assert()

Whitelist the remaining usages of assert(), and reinstate the PHPCS sniff
that forbids usage of it. Add FIXME comments as well, so any casual readers
of the code will not think that the disabling and usage is intentional.

Change-Id: I7cabe715c0e6aa6a9ef3ffe5657f3de7fd8e662b
.phpcs.xml
includes/diff/DiffEngine.php
includes/diff/WordAccumulator.php
includes/parser/Preprocessor_DOM.php
includes/parser/Preprocessor_Hash.php