widgets: Remove redundant equality check in SelectWithInputWidget
authorDerick Alangi <alangiderick@gmail.com>
Mon, 11 Feb 2019 14:59:36 +0000 (15:59 +0100)
committerDerick Alangi <alangiderick@gmail.com>
Tue, 12 Feb 2019 04:53:29 +0000 (05:53 +0100)
commitef220ef5dca71ddbf96bb873b9adcb2ff290721b
treef4f6911e1430311e557ba97da4ba6e6d9457e330
parent7099937b42cdf52948ae0c3c5f761ca573f7e530
widgets: Remove redundant equality check in SelectWithInputWidget

The check `if ( $config['disabled'] == true )` is the same as the
check `if ( $config['disabled'] )`. Was this intentional or was it
supposed to be a test for equality and type (===)? If not, then I
think this patch removes the irrelevancy.

Clearly, if the $config['disabled'] is set to false, the isset()
check will return true but the second check will fail even with
this patch as it does the same thing.

Change-Id: Ibbe5b4949590f8ac954f613236056dd2e6dd18ba
includes/widget/SelectWithInputWidget.php