Un-blacklist PhanUndeclaredVariable
authorErik Bernhardson <ebernhardson@wikimedia.org>
Wed, 18 Jan 2017 00:48:59 +0000 (16:48 -0800)
committerErik Bernhardson <ebernhardson@wikimedia.org>
Wed, 18 Jan 2017 21:07:39 +0000 (13:07 -0800)
commite5b8bf49420fd9f0b11d8594cd0ff4a353c513e7
tree783f3a4ddb391b03c85307f1a310c5c9cbb5e18a
parentf4ed4cd93907bd4ff0fd3490daaad5ce7bbbba28
Un-blacklist PhanUndeclaredVariable

Undeclared variables are a very common error type that we want to catch
as often as possible. To avoid needing to refactor a variety of global
level code (mostly in old-style maintenance scripts) this ignores
undeclared variables in global scope. This is still a good improvement
over what was happening previously.

Change-Id: I50b41d571724244552074b9408abbdf6160aca59
12 files changed:
includes/api/ApiFeedWatchlist.php
includes/api/ApiUpload.php
includes/installer/Installer.php
includes/libs/StringUtils.php
includes/libs/rdbms/lbfactory/LBFactory.php
includes/libs/xmp/XMP.php
includes/parser/DateFormatter.php
includes/specials/pagers/MergeHistoryPager.php
includes/tidy/Balancer.php
maintenance/generateJsonI18n.php
maintenance/rebuildtextindex.php
tests/phan/config.php