Pass $key into CommentStore methods and use MediawikiServices
authoraddshore <addshorewiki@gmail.com>
Wed, 24 Jan 2018 23:41:01 +0000 (15:41 -0800)
committerAddshore <addshorewiki@gmail.com>
Mon, 5 Feb 2018 15:34:12 +0000 (15:34 +0000)
commite5879da149afe183ce889ef6f4158086c9b4735f
tree30292e560c9ac9d1d1cfb0c560a916f6467786fc
parent785ffe2408faa6f17240648d9dac4ed6dbfdd613
Pass $key into CommentStore methods and use MediawikiServices

This allows CommentStore to be added to MediaWikiServices
without the need of an aditional Factory.

This change includes a compatability layer to allow the behaviour
from 1.30 to continue to be used while deprecated.

CommentStore::newKey has been deprecated.
Keys are now passed into the public methods of CommentStore
where needed.
The following CommentStore methods have had their signatures changed
to introduced a $key parameter, but when used in conjunction with
CommentStore::newKey behaviour will remain unchanged:
  * CommentStore::getFields
  * CommentStore::getJoin
  * CommentStore::getComment
  * CommentStore::getCommentLegacy
  * CommentStore::insert
  * CommentStore::insertWithTemplate

Change-Id: I3abb62a5cfb0dcd456da9f4eb35583476ae41cfb
50 files changed:
RELEASE-NOTES-1.31
includes/Block.php
includes/CommentStore.php
includes/EditPage.php
includes/FeedUtils.php
includes/MediaWikiServices.php
includes/Revision.php
includes/ServiceWiring.php
includes/Storage/RevisionStore.php
includes/Title.php
includes/api/ApiQueryAllUsers.php
includes/api/ApiQueryBase.php
includes/api/ApiQueryBlocks.php
includes/api/ApiQueryDeletedrevs.php
includes/api/ApiQueryFilearchive.php
includes/api/ApiQueryLogEvents.php
includes/api/ApiQueryProtectedTitles.php
includes/api/ApiQueryRecentChanges.php
includes/api/ApiQueryUserContributions.php
includes/api/ApiQueryUsers.php
includes/api/ApiQueryWatchlist.php
includes/changes/RecentChange.php
includes/export/WikiExporter.php
includes/export/XmlDumpWriter.php
includes/filerepo/file/ArchivedFile.php
includes/filerepo/file/LocalFile.php
includes/filerepo/file/OldLocalFile.php
includes/import/WikiRevision.php
includes/logging/LogEntry.php
includes/logging/LogPage.php
includes/page/WikiPage.php
includes/rcfeed/IRCColourfulRCFeedFormatter.php
includes/revisiondelete/RevDelLogItem.php
includes/revisiondelete/RevDelLogList.php
includes/specials/SpecialNewpages.php
includes/specials/pagers/BlockListPager.php
includes/specials/pagers/DeletedContribsPager.php
includes/specials/pagers/ImageListPager.php
includes/specials/pagers/NewPagesPager.php
includes/specials/pagers/ProtectedPagesPager.php
includes/watcheditem/WatchedItemQueryService.php
maintenance/orphans.php
maintenance/rebuildrecentchanges.php
tests/phpunit/includes/CommentStoreTest.php
tests/phpunit/includes/MediaWikiServicesTest.php
tests/phpunit/includes/PageArchiveTest.php
tests/phpunit/includes/RevisionTest.php
tests/phpunit/includes/Storage/RevisionStoreTest.php
tests/phpunit/includes/page/WikiPageDbTestBase.php
tests/phpunit/includes/watcheditem/WatchedItemQueryServiceUnitTest.php