Disallow setting DBO_IGNORE in Database for sanity
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 23 Nov 2017 10:17:14 +0000 (02:17 -0800)
committerKrinkle <krinklemail@gmail.com>
Wed, 29 Nov 2017 21:31:03 +0000 (21:31 +0000)
commite0805d32e4e00a530dd8445863b2bf9e51ce2f74
tree73580f1a559b8d8b779019651920ca2fa67fb861
parent70a602dde40e3694f8ef8b9c779a528c17a48f42
Disallow setting DBO_IGNORE in Database for sanity

In the off chance something called this, it would break all
sorts of code that expects that either query result functions
either succeed or throw an error.

Callers are not expected to have to check if the result of
a query is meaningful or false due to an error.

Change-Id: I0b4fe1403f55a399ffd40817ed12f857087d6f83
includes/libs/rdbms/database/Database.php
tests/phpunit/includes/libs/rdbms/database/DatabaseMysqlBaseTest.php