Make $wgEmailConfirmToEdit only affect edit actions.
authorBrian Wolff <bawolff+wn@gmail.com>
Fri, 26 Aug 2016 01:29:58 +0000 (01:29 +0000)
committerTim Starling <tstarling@wikimedia.org>
Tue, 12 Jun 2018 00:13:18 +0000 (00:13 +0000)
commitd561f646b9b8424bd79cfc14729a622a143d9f12
treea39f544d4f59fe6e34dcdd46084ac33e3bcde579
parent6fdfad6ddd484e2ed2a3386e84f26d5236aafbe7
Make $wgEmailConfirmToEdit only affect edit actions.

Previously it would affect all actions that use Title::userCan.
This used to be less noticable, but recently was expanded to include
the 'read' action. This only affected the case where both
$wgBlockDisablesLogin and $wgEmailConfirmedToEdit were enabled.

I don't think anyone was relying on the old behaviour as it was
undocumented, and only affected obscure permissions (checked with
Title::userCan and not depending on "edit" rights)

Follow-up b675be2083

Bug: T143790
Change-Id: I4ad93ed78de4f1ed444f73df6dc26d405a67e553
includes/Title.php
tests/phpunit/includes/TitlePermissionTest.php