Fix required field calculation in AuthenticationRequest
authorGergő Tisza <gtisza@wikimedia.org>
Sun, 29 May 2016 21:14:28 +0000 (21:14 +0000)
committerGergő Tisza <gtisza@wikimedia.org>
Mon, 30 May 2016 11:57:58 +0000 (11:57 +0000)
commitd0e6051b5ce8a1fa6089d0761ab91e28484f2f2d
tree510665105df1238f0c2f011007a181ffa548676d
parent5f0f8c52051515762306cf2ef5a9c72d9854bead
Fix required field calculation in AuthenticationRequest

Instead of only flagging fields which are required by a request
needed by all primairy providers, it should be enough if all
requests needed by some primary provider require that field.

Also make CreationReasonAuthenticationRequest non-required so that
the list of required form fields is more in sync with that of
pre-AuthManager code.

Bug: T85853
Change-Id: I9d33bd22295758cc532a260b1848616b41d94f12
includes/auth/AuthenticationRequest.php
includes/auth/CreationReasonAuthenticationRequest.php
tests/phpunit/includes/auth/AuthenticationRequestTest.php