Database: Allow selectFieldValues() to accept SQL fragments
authorBrad Jorsch <bjorsch@wikimedia.org>
Wed, 17 Oct 2018 15:26:51 +0000 (11:26 -0400)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 17 Oct 2018 22:21:40 +0000 (22:21 +0000)
commitc5a5b022400318e52638a4d34369ddbb74d7a21b
tree6b5cbc7e8969aa6bebcc20816b9288896081fb76
parentc75059dacbb972683139fb848be986806bf0233e
Database: Allow selectFieldValues() to accept SQL fragments

The documentation says "This must be a valid SQL fragment", but as
written it breaks if given anything other than a field name. It's easy
enough to fix by adding an alias to the internal select() call.

Bug: T201781
Change-Id: I76428af6d3aadc266254fdb24109a0ac2db3761f
includes/libs/rdbms/database/Database.php
tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php
tests/phpunit/includes/libs/rdbms/database/DatabaseTest.php