rdbms: various field name and style cleanups to Database
authorAaron Schulz <aschulz@wikimedia.org>
Thu, 22 Aug 2019 00:45:43 +0000 (17:45 -0700)
committerKrinkle <krinklemail@gmail.com>
Fri, 23 Aug 2019 20:34:12 +0000 (20:34 +0000)
commitb9e68b2d5032ae5d343ae4fad56aeea4a953960b
treec53a403950c547188e17bfde144f6582e89443c4
parenta158a4fb32b57027f0dece321e4c18af4687454d
rdbms: various field name and style cleanups to Database

Rename Database::hasFlags() to sound less similar to getFlag()/setFlag().
The order of class fields is roughly:
* Objects and resources
* Configuration
* Mutable options that do not have to be kept in sync with the connection
* Session level state tracking (should be in sync with the connection)
* Transaction level state tracking (should be in sync with the connection)
* Results from or timestamp of the last time a certain event occurred

Change-Id: Ibdca2fefe7ed2c792344c5602b5191a950eed933
includes/libs/rdbms/database/Database.php
tests/phpunit/includes/db/DatabaseTestHelper.php