dépôts / lhc / web / wiklou.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1674c84) | patch
More robust, cleaned up MessageTest
authorThiemo Mättig <thiemo.maettig@wikimedia.de>
Fri, 11 Nov 2016 09:53:10 +0000 (10:53 +0100)
committerThiemo Mättig (WMDE) <thiemo.maettig@wikimedia.de>
Fri, 11 Nov 2016 16:48:14 +0000 (16:48 +0000)
commitae72e3577fa8bb28335e9ece016784ab8838dfc9
tree34c63518aa8f3186c5e878c458fe4d1ad75a9ec3tree | snapshot
parent1674c8413a4ec5065040408a8cbdb948c74bf6facommit | diff
More robust, cleaned up MessageTest

This is a direct follow up to my comments in Ia6ec10d.

Relevant for T146416 are the two messages I added. They explain why these
assertions are duplicated.

assertEquals behaves bogus when used with strings, especially when used
with formatters and parsers, which is the case here. For example,
assertEquals( '9a', 9 ) succeeds. assertEquals is useful when comparing
objects.

Bug: T146416
Change-Id: Ie8df41b3ce6678f3add55bab6701b56b66447a2e
tests/phpunit/includes/MessageTest.php diff | blob | history
Wiklou, le Wiki du Wiklou