AuthManager: Don't invalidate BotPasswords if a password reset email is sent
authorBrad Jorsch <bjorsch@wikimedia.org>
Tue, 17 Jul 2018 20:18:59 +0000 (16:18 -0400)
committerBrad Jorsch <bjorsch@wikimedia.org>
Tue, 17 Jul 2018 20:25:28 +0000 (16:25 -0400)
commitac0c80a6d696034f697ae86315f8a167409dae77
tree577654f20b8215fcfc9274481678bc8ac6e7ccb6
parent8785fa24c96f08f18f308a9e36f9e17d1b62552b
AuthManager: Don't invalidate BotPasswords if a password reset email is sent

There's a difference between addition of credentials, which doesn't
need to invaliate BotPasswords, and changing or removal of credentials,
which does.

It seems most straightforward for the caller of
AuthManager::changeAuthenticationData() to know which is intended, so
let's add a flag there.

Bug: T199809
Change-Id: Ib8405734e605b94f3f0b66596ad95784cb365e4f
includes/auth/AuthManager.php
includes/auth/ConfirmLinkSecondaryAuthenticationProvider.php
includes/user/PasswordReset.php