jobqueue: Change internal $params logic to teach Phan (3)
authorTimo Tijhof <krinklemail@gmail.com>
Fri, 5 Apr 2019 00:09:30 +0000 (01:09 +0100)
committerKrinkle <krinklemail@gmail.com>
Fri, 5 Apr 2019 18:01:12 +0000 (18:01 +0000)
commita94c300c0a1bbb9eece351eac2a44ea464da195d
tree618afbf12119efca87767910f1be64c56ba0aeae
parentf01e440304a09f14274260f37c9425a42db6145b
jobqueue: Change internal $params logic to teach Phan (3)

Follows-up 9b4938c40d02c4bff6f1558, and 766549999c.

It seems despite being optional and documented as 'array|Title',
Phan still thinks it is wrong to pass Title.

Try removing the explicit default of empty array,
the lower code already does this anyway.

This should fix build failures that are preventing merges
in repos where Phan is finding Job::__construct(string, Title)
where it currently fails as follows:

 CompileArticleMetadataJob.php:11
 PhanTypeMismatchArgument Argument 2 (params) is …\Title|string but
 \Job::__construct() takes array

Change-Id: I1c3aee273e0917e30b9c18b49b24fc7f966ff57c
includes/jobqueue/Job.php