upload: Simplify UploadStashTest by using getNewTempFile()
authorTimo Tijhof <krinklemail@gmail.com>
Tue, 7 Nov 2017 06:45:34 +0000 (22:45 -0800)
committerTimo Tijhof <krinklemail@gmail.com>
Tue, 7 Nov 2017 06:45:34 +0000 (22:45 -0800)
commita4eb5c9a8a3913b13ae2735d44aec5adb9d5731b
tree19a475508cac6a82ab6e9d47d7f194aaa131e529
parentf5baf27bb89a4306e77e7ad1183791f775888199
upload: Simplify UploadStashTest by using getNewTempFile()

The parent class has a built-in list that tracks these files and
deletes them in a teardown.

I was unable to reproduce a case where $path + '.' is created by
MediaWiki. As far as I can tell, no current code exists in core
that would do this. If it does exist, we can keep the tearDown()
override with just that second case, but I'm removing it for now,
given it doesn't appear to be used.

Change-Id: I5847b7b266f1393d983aeb4b115bc0ae000e3547
tests/phpunit/includes/upload/UploadStashTest.php