ORMRow must not ignore failures on insert by deault.
authordaniel <daniel.kinzler@wikimedia.de>
Wed, 31 Oct 2012 14:37:39 +0000 (15:37 +0100)
committerdaniel <daniel.kinzler@wikimedia.de>
Wed, 31 Oct 2012 19:15:02 +0000 (20:15 +0100)
commit980da6d6a7fca8dd58f11f4116def55d59b5b17d
treef6182e9deec1b1dd4dc0e1fe1c2c2d903521a7b3
parent8eb98ba47bc5d55a9d9f7718c6083d4d58aded0e
ORMRow must not ignore failures on insert by deault.

ORMRow shouldn't apply the "IGNORE" modifier for insertions by default.
IGNORE means pretending the insert was successfull even if it wasn't.
That's not a good default, and for some databases (like sqlite), may
actually hide errors beyond key conflicts.

Change-Id: I8b00cd03a459419441195ed25091385371b027a5
includes/db/ORMRow.php
includes/site/SitesTable.php
tests/phpunit/includes/db/ORMRowTest.php
tests/phpunit/includes/db/TestORMRowTest.php
tests/phpunit/includes/site/SiteObjectTest.php