Replace deprecated calls to OutputPage::parseInline()
authorC. Scott Ananian <cscott@cscott.net>
Fri, 26 Oct 2018 15:39:07 +0000 (11:39 -0400)
committerC. Scott Ananian <cscott@cscott.net>
Mon, 29 Oct 2018 19:34:43 +0000 (15:34 -0400)
commit97d9659904424afe2c8b9df3c17438b051529f5e
tree762fadae0a135d76ded58112c34dfddd9d8d72a2
parenta3f63785eebfa2f729d42da880b6722736ef1e7d
Replace deprecated calls to OutputPage::parseInline()

Every one of these seemed to previously use the wrong value for
`$interface` -- the interface messages in ProtectionForm and
SpecialVersion were being parsed as content language (which is the
default for `OutputPage::parseInline`), and the one place where we
have actual data in the content language (the user signature, which
gets parsed in the content language with the rest of the (talk) page
content, see Parser.php::pstPass2) was being parsed as an interface
message!

Forcing the caller to be very explicit about AsContent() or AsInterface()
will help mitigate this in the future, one hopes.

Bug: T198214
Change-Id: Ib9d5d8d733a47c967bdf7db3e23fa39f11687063
includes/ProtectionForm.php
includes/preferences/DefaultPreferencesFactory.php
includes/specials/SpecialVersion.php