Make use of the list() feature where it makes sense
authorThiemo Kreuz <thiemo.kreuz@wikimedia.de>
Sun, 24 Mar 2019 14:04:32 +0000 (15:04 +0100)
committerThiemo Kreuz (WMDE) <thiemo.kreuz@wikimedia.de>
Sun, 24 Mar 2019 20:12:23 +0000 (20:12 +0000)
commit9314453c93e9daa502a706063b66d003adcbee0b
treeabddbf296449ba18e485e9e26384312e95ffda0b
parent0449f653c7147328e9ddcce9861733fc29e6f961
Make use of the list() feature where it makes sense

This code is functionally identical, but less error prone (not so easy
to forget or mix these numerical indexes).

This patch happens to touch the Parser, which might be a bit scary. We
can remove this file from this patch if you prefer.

Change-Id: I8cbe3a9a6725d1c42b86e67678c1af15fbc5961a
15 files changed:
includes/Linker.php
includes/cache/localisation/LCStoreStaticArray.php
includes/diff/DiffEngine.php
includes/gallery/TraditionalImageGallery.php
includes/installer/DatabaseUpdater.php
includes/libs/rdbms/database/DatabaseMysqli.php
includes/page/ImagePage.php
includes/parser/LinkHolderArray.php
includes/parser/Parser.php
includes/utils/UIDGenerator.php
languages/classes/LanguageKk_cyrl.php
maintenance/cleanupInvalidDbKeys.php
maintenance/includes/BackupDumper.php
maintenance/mysql.php
tests/phpunit/includes/specials/QueryAllSpecialPagesTest.php