$wgHttpsPort should only be used in very special cases
authorTim Starling <tstarling@wikimedia.org>
Tue, 10 Jul 2018 00:05:07 +0000 (10:05 +1000)
committerTim Starling <tstarling@wikimedia.org>
Wed, 11 Jul 2018 02:31:48 +0000 (12:31 +1000)
commit89629154496932504bebbcb06d85e94cb64b0a0d
tree877708d029e5cd2dec3a9907e820c43b76ec8ef9
parent874f5f7f0a959f09c43c5408e04d20bce4a426b5
$wgHttpsPort should only be used in very special cases

When expanding a URL, don't overwrite an explicitly specified port or
add a port to a foreign URL. $wgHttpsPort is only useful for a very
specific case: when $wgServer is protocol-relative and HTTPS is
requested.

Documented correct use of $wgHttpsPort in DefaultSettings.php. Fixed
invalid "@see", in Doxygen it can only point to "classes, functions,
methods, variables, files or URL".

Added test cases which previously failed.

Change-Id: Id65c58300d22712212b6605711ff916916e8768b
includes/DefaultSettings.php
includes/GlobalFunctions.php
tests/phpunit/includes/GlobalFunctions/wfExpandUrlTest.php