rdbms: make resolveDomainID() use more consistent in LoadBalancer
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 7 May 2019 17:57:09 +0000 (10:57 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Thu, 30 May 2019 04:49:29 +0000 (21:49 -0700)
commit8669e0fbe6c3ca977dd14f7057de1b9f4da41c55
treec7e5b67897de9bd06994b63c31f36cbd6298563a
parent74881a7eacdb39fc22fb7b60b6f12d1c3ee21dc3
rdbms: make resolveDomainID() use more consistent in LoadBalancer

Use the method in getConnection()/openConnection() and make it
handle the local domain alias as well.

Also:
* Move some code to a new getConnectionIndex() method.
* Make the text of various index/domain exceptions more consistent.
* Improve some auto-commit flag code comments.

Change-Id: I7e0d4f2134ee91ad60b0d34bf01e05115193b04a
includes/libs/rdbms/loadbalancer/ILoadBalancer.php
includes/libs/rdbms/loadbalancer/LoadBalancer.php
tests/phpunit/includes/db/LoadBalancerTest.php