Deprecate Language::markNoConversion, which confuses readers
authorC. Scott Ananian <cscott@cscott.net>
Fri, 8 Jun 2018 16:18:05 +0000 (12:18 -0400)
committerC. Scott Ananian <cscott@cscott.net>
Wed, 13 Jun 2018 17:26:58 +0000 (13:26 -0400)
commit7de2c566dd0fb4d0d994867094a00899df107420
treeaa2ea06228afb64418d7a4df7b312efb1dd35a5b
parent70c79f3fc255a5da5650f275bceecba72b8e3f91
Deprecate Language::markNoConversion, which confuses readers

Language::markNoConversion is used only within Parser.php and differs
from LanguageConverter::markNoConversion in that, contrary to its name
and its namesake, it only protects *things which look like URLs* from
language conversion.

This wasted several days of my time before I realized what was going on.
It's needless; just hoist the "looks like a URL" special casing inline
to the single place where that functionality is used.  (And I wonder
if the "looks like a URL" case is actually needed at all any more,
since most of those cases are probably free external links, which
go through a different code path, not bracketed external links.)

This is a clean-up to the clean-up that liangent performed in 2012
with e01adbfc0bd9f39adffc1f955ccc711e73818194.

Change-Id: I80479600f34170651732b032e8881855aa1204d8
RELEASE-NOTES-1.32
includes/parser/Parser.php
languages/Language.php