objectcache: Fix HashBagOStuffTest test in PHP 7.1
authorTimo Tijhof <krinklemail@gmail.com>
Fri, 1 Dec 2017 21:28:36 +0000 (13:28 -0800)
committerTimo Tijhof <krinklemail@gmail.com>
Fri, 1 Dec 2017 21:28:36 +0000 (13:28 -0800)
commit7dbc5b0fe63a10573ebf0f705d6857b3382288dd
treee7b2ec972e8be782e906408d6a6080951703f401
parentbd78292e75ac7a4d841018e366b73bbba3e051cb
objectcache: Fix HashBagOStuffTest test in PHP 7.1

> There was 1 error:
>
> 1) HashBagOStuffTest::testEvictionAdd
> A non-numeric value encountered
>
> tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php:106

This warning is new in PHP 7.1, however the behaviour is not new.
This code was already not behaving as it should have. Concatenation
preceeds addition/multiplication. As such, this was producing
(int)-10 each time instead of (str)"key0" through (str)"key10".

Change-Id: Ibb1a59e373740772f02dfec77ee7ebd9d181d852
tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php