resourceloader: Improve coverage in ResourceLoaderTest.php
authorTimo Tijhof <krinklemail@gmail.com>
Thu, 25 Aug 2016 01:50:30 +0000 (18:50 -0700)
committerTimo Tijhof <krinklemail@gmail.com>
Thu, 25 Aug 2016 01:56:20 +0000 (18:56 -0700)
commit7dbad8562c68d587244c1663279b602028511a92
treec2fdc32a7897b1ada4d43980c19f592a2aef94da
parent3ea818c42ba9f2115a4dd5f528a40d44e2e0afd8
resourceloader: Improve coverage in ResourceLoaderTest.php

* Fix signature of makeLoaderSourcesScript() to match
  the change in behaviour since e103ba265.

* Consistently order providers before the test.

* Simplify testRegisterValid() and remove needless @depends.

* Remove unused private method stripNoflip().

Coverage:

* Expand test coverage for register().

* Add tests for getModuleNames().

* Add tests for getModule().

* Expand test coverage for addSource().
  (case of invalid array)

* Expand test coverage for makeLoaderImplementScript().
  (case of unwrapped user script, and case of invalid scripts)

* Add tests for makeLoaderSourcesScript().

Change-Id: Ibca3e486fcd3664f171f135327a0f340ee6da9ee
includes/resourceloader/ResourceLoader.php
tests/TestsAutoLoader.php
tests/phpunit/ResourceLoaderTestCase.php
tests/phpunit/includes/resourceloader/ResourceLoaderStartUpModuleTest.php
tests/phpunit/includes/resourceloader/ResourceLoaderTest.php