Fix/suppress misc phan errors (#2)
authorKunal Mehta <legoktm@member.fsf.org>
Fri, 22 Mar 2019 01:12:50 +0000 (18:12 -0700)
committerKunal Mehta <legoktm@member.fsf.org>
Fri, 5 Apr 2019 23:12:18 +0000 (16:12 -0700)
commit7bd9073c4b9d14a31a8a3b539fcbb9b3877d824d
treeb5b74217e2f5ebe3f37e3e13194987195a8d25b9
parentf5af72470cdd6139a4e3e4f31699b1e84f2d5a6d
Fix/suppress misc phan errors (#2)

* Title: phan false positive
* McrUndoAction: fixed improper use of @param
* UploadSourceAdapter: fixed wrong type
* XmlTypeCheck: Use null so phan doesn't think we're trying to call the
function ''
* Database: phan false positive
* SpecialBlock: Use phan's advanced type documentation so phan knows
specifically what's being returned
* ChangesListSpecialPage: phan false positive
* BatchRowUpdate: Have default callback take a parameter so phan doesn't
think too many arguments are being passed
* MimeAnalyzer: left FIXME for relying on PHP 7.1 unpack() signature
* LanguageConverter: Specify types for $mTables since phan couldn't
determine it automatically
* preprocessorFuzzTest: Implement User::load() method signature

Change-Id: I08080ab636c5fe67ea6a4e14b2212d7523606e21
13 files changed:
.phan/config.php
includes/Title.php
includes/actions/McrUndoAction.php
includes/htmlform/OOUIHTMLForm.php
includes/import/UploadSourceAdapter.php
includes/libs/mime/MimeAnalyzer.php
includes/libs/mime/XmlTypeCheck.php
includes/libs/rdbms/database/Database.php
includes/specialpage/ChangesListSpecialPage.php
includes/specials/SpecialBlock.php
includes/utils/BatchRowUpdate.php
languages/LanguageConverter.php
maintenance/preprocessorFuzzTest.php