Revert "objectcache: fix race conditions in RedisBagOStuff::incr()"
authorKrinkle <krinklemail@gmail.com>
Thu, 18 Jul 2019 16:41:24 +0000 (16:41 +0000)
committerAaron Schulz <aschulz@wikimedia.org>
Thu, 18 Jul 2019 18:02:01 +0000 (18:02 +0000)
commit7b1b22ac80d669263979eda1c992103e8321695d
tree34156dc692be842ec5fe8e0296e014e9b6ff830d
parent8ee4d6a0c9748aedd5bdd7dbb982804a9acb34e0
Revert "objectcache: fix race conditions in RedisBagOStuff::incr()"

This commit reverts most of 7e647d2f0f5b, but keeps unrelated code
clean ups from it, as well as the conflicting changes from d8b952ae47.

From WMF production nutcracker:

> nc_redis.c parsed unsupported command 'WATCH'

The use of WATCH, in addition to failing the commands that use it,
also appears to also have caused a chain reaction making nutcracker
intermittently unavailable to other web requests.

Bug: T228303
Change-Id: Ic37efc2963b147e461837571ae0b65acf3f60cb4
includes/libs/objectcache/RedisBagOStuff.php