Alter two uses of hasOrMadeRecentMasterChanges() for consistency
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 19 Mar 2019 03:31:54 +0000 (20:31 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Tue, 23 Apr 2019 18:34:09 +0000 (11:34 -0700)
commit7a69b598f2450c32ba988bdbcef262752e298485
tree926d1e0e7403765f83915c875cce7eb68736e638
parent44a2f3e5ee6d4f1d484f9878de4c22c0e7d8d76d
Alter two uses of hasOrMadeRecentMasterChanges() for consistency

Rather than have the behavior vary and possibly break code or tests
when small changes happen, make User/NameTableStore more explicit
about when cache key purges happens.

This should reduce problems with certain fragile tests, such as those
that could be affected by 03908112635f when --use-normal tables is not
used. Ideally, any fragility should be ironed out of effected code.

Change-Id: Ibe5d1bb4bece2526bc0da99648f7ba73bdc0ffa5
includes/Storage/NameTableStore.php
includes/user/User.php
tests/phpunit/includes/Storage/NameTableStoreTest.php