Database: Allow selectFieldValues() to accept SQL fragments
authorBrad Jorsch <bjorsch@wikimedia.org>
Wed, 17 Oct 2018 15:26:51 +0000 (11:26 -0400)
committerLegoktm <legoktm@member.fsf.org>
Sun, 21 Oct 2018 15:41:01 +0000 (15:41 +0000)
commit7065200b036d4bbf0c46f4b236d761a79b57215e
tree83901312133eae58432a4a7e2db87f0c56d636bf
parente62a8361d75344ab15e8def60cb7f2c6c4db2adb
Database: Allow selectFieldValues() to accept SQL fragments

The documentation says "This must be a valid SQL fragment", but as
written it breaks if given anything other than a field name. It's easy
enough to fix by adding an alias to the internal select() call.

Bug: T201781
Change-Id: I76428af6d3aadc266254fdb24109a0ac2db3761f
(cherry picked from commit c5a5b022400318e52638a4d34369ddbb74d7a21b)
includes/libs/rdbms/database/Database.php
tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php
tests/phpunit/includes/libs/rdbms/database/DatabaseTest.php