Fix TextPassDumperDatabaseTest::testPrefetchPlain postgres failures
authorAaron Schulz <aschulz@wikimedia.org>
Fri, 26 May 2017 21:38:07 +0000 (14:38 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Fri, 26 May 2017 21:43:17 +0000 (21:43 +0000)
commit6fb5844fec8fb1ec727ada77406c6050571d2e3a
treefb71c76d5e9804d1a04094235fdbaffbddda29e3
parent121e95dec9defea5c185f3eeb966c795a3e5184e
Fix TextPassDumperDatabaseTest::testPrefetchPlain postgres failures

The insertId() method was returning a string, which caused the
returnValueMap not to trigger due to int/string mismatches.

Also add sanity integer cast to WikiPage::insertOn().

Added a few more type docs.

Bug: T75174
Change-Id: Id1090f3e3d0481272a3d13c3af8f2588f06dc912
includes/libs/rdbms/database/DatabasePostgres.php
includes/page/WikiPage.php
maintenance/backupPrefetch.inc
maintenance/dumpTextPass.php
tests/phpunit/maintenance/backupTextPassTest.php