Convert JobRunner to using beginMasterChanges()
authorAaron Schulz <aschulz@wikimedia.org>
Tue, 6 Sep 2016 22:25:53 +0000 (15:25 -0700)
committerAaron Schulz <aschulz@wikimedia.org>
Wed, 7 Sep 2016 03:56:37 +0000 (03:56 +0000)
commit6c73b32fd5b2a0c17d0fb32935804b6457ccd992
treed75c23ce5f54d6ec32f5f0ec7c3a537e28748ade
parentb2585a95b27fc196bcded4c146d1251d9d7740b9
Convert JobRunner to using beginMasterChanges()

This lets the runJobs.php $wgCommandLineMode hack be removed.

Some fixes based on unit tests:
* Only call applyTransactionRoundFlags() for master connections
  for transaction rounds from beginMasterChanges().
* Also cleaned up the commitAndWaitForReplication() reset logic.
* Removed deprecated DataUpdate::doUpdate() calls from jobs
  since they cannot nest in a transaction round.

Change-Id: Ia9b91f539dc11a5c05bdac4bcd99d6615c4dc48d
includes/db/loadbalancer/LBFactory.php
includes/db/loadbalancer/LoadBalancer.php
includes/jobqueue/JobRunner.php
includes/jobqueue/jobs/DeleteLinksJob.php
includes/jobqueue/jobs/RefreshLinksJob.php
maintenance/runJobs.php