Fix phan errors by improving documentation (#10)
authorKunal Mehta <legoktm@member.fsf.org>
Sat, 6 Apr 2019 07:07:54 +0000 (00:07 -0700)
committerKunal Mehta <legoktm@member.fsf.org>
Sat, 6 Apr 2019 07:07:54 +0000 (00:07 -0700)
commit6b80d71f191ac73b914921846cadd3d5bf0e0206
treeab47d191906716d2dc91b36a03827fcaf4ec5a2b
parente77937bbac44cf179800d4e6abc5fc391b1a9735
Fix phan errors by improving documentation (#10)

PhanTypeExpectedObjectPropAccess was flagged by phan in the
DatabaseMysqli and Preprocessor_Hash classes.

In Database, the $conn property might be a standard object, such as
`\mysqli`, which is not a resource.

In Preprocessor, phan was getting confused and thinking
PPDStack::getCurrentPart() was returning bool, and not a PPDPart object.
Adding explicit documentation about the return value fixed that.

Change-Id: I0a3aa219693da5cb46ff9c0936841ed740c6968a
.phan/config.php
includes/libs/rdbms/database/Database.php
includes/parser/Preprocessor_DOM.php