Setup: Move wgActionPath logic to PathRouter
authorTimo Tijhof <krinklemail@gmail.com>
Sat, 31 Aug 2019 22:05:50 +0000 (23:05 +0100)
committerKrinkle <krinklemail@gmail.com>
Wed, 4 Sep 2019 20:29:03 +0000 (20:29 +0000)
commit64281b6c524f54863174768c025dfe698948fc3f
tree197b804ef7da585e4ddf5dba40c03de83b41c120
parent209f2d220fd90f323fcfa6b303a11ca9344ff8da
Setup: Move wgActionPath logic to PathRouter

This is only relevant when processing page views or when constructing
Title urls with an 'action' query. Pretty important stuff, and worth
optimising for if we had to choose, but we can defer it in this case
without slowing it down, which is better for everything else.

It also means we don't mutate configuration (beyond setting whole values
as dynamic defaults), which seems desirable, and makes the overall behaviour
easier to test. Handling absence of 'view' should be PathRouter's
responsibility, not Setup.

Bug: T189966
Change-Id: I9c1eea2dcea74be0e283eb2b175268315ced1793
includes/PathRouter.php
includes/Setup.php
includes/Title.php
includes/WebRequest.php