Fix misc phan errors by adjusting documentation (#8)
authorKunal Mehta <legoktm@member.fsf.org>
Sat, 6 Apr 2019 06:31:16 +0000 (23:31 -0700)
committerKunal Mehta <legoktm@member.fsf.org>
Sat, 6 Apr 2019 06:31:16 +0000 (23:31 -0700)
commit5f8d76336dba61aa6ce495a92e30367368aaa651
tree1b3d044dfb161832e3089d2d676b20ab005bca36
parent8c98f517782610282564116b1c67ff4c4c7e0a63
Fix misc phan errors by adjusting documentation (#8)

PhanTypeInvalidRightOperand was triggering on
ApiQueryBase::showHiddenUsersAddBlockInfo() on the line
`$actorQuery['tables'] + $commentQuery['tables']` (and the next one).
For whatever reason, phan was unable to automatically understand that
the right side was an array (though it was able to understand
$actorQuery, which has nearly identical code...), so I added more
specific hinting to CommentStore::getJoin() using phan's union types,
which resolved the issue.

And incorrect documentation on LogEntry::getDeleted() was triggering
PhanTypeMismatchBitwiseBinaryOperands since you can't do bitwise
operations on a string and an integer.

Change-Id: I13b791e4b754ffbc340b55cfb752e2d9226f1949
.phan/config.php
includes/CommentStore.php
includes/logging/LogEntry.php