LockManagerGroupFactory to replace singletons
authorAryeh Gregor <ayg@aryeh.name>
Thu, 15 Aug 2019 18:07:36 +0000 (21:07 +0300)
committerAryeh Gregor <ayg@aryeh.name>
Tue, 27 Aug 2019 10:19:15 +0000 (13:19 +0300)
commit5a6c18a0863fad234a513bcd61a2076f28433d7e
tree869a415898b9f97d0093e7e8948272c0a7271a93
parent53d16a8c1d4779b464c71d2f3a3f3f82445ba2b3
LockManagerGroupFactory to replace singletons

100% test coverage of code that appears to be working and used, in both
LockManagerGroupFactory and also LockManagerGroup. Where possible I
wrote it as unit tests. One preexisting code path seems to be broken and
I marked the test as skipped. Two methods look unused and perhaps not
especially helpful, so I didn't write tests for them yet in case we want
to just get rid of them instead.

Change-Id: Iaa7354f31c451b87773468609c674a3bf1d4382f
autoload.php
includes/ForkController.php
includes/MediaWikiServices.php
includes/ServiceWiring.php
includes/filebackend/lockmanager/LockManagerGroup.php
includes/filebackend/lockmanager/LockManagerGroupFactory.php [new file with mode: 0644]
tests/parser/ParserTestRunner.php
tests/phpunit/unit/includes/filebackend/lockmanager/LockManagerGroupFactoryTest.php [new file with mode: 0644]
tests/phpunit/unit/includes/filebackend/lockmanager/LockManagerGroupTest.php [new file with mode: 0644]