Disable automatic cache headers associated with starting a session
authorBryan Davis <bd808@wikimedia.org>
Mon, 1 Feb 2016 04:39:10 +0000 (21:39 -0700)
committerAnomie <bjorsch@wikimedia.org>
Wed, 3 Feb 2016 21:45:28 +0000 (21:45 +0000)
commit514725e7fefe47c0187b9ea94aa3dbf49bd44806
treefa2296a5fc35f83bbacee74fc8a3a64dbae39064
parent2257fe42288cca06376e5caf45aa32da9d0216cf
Disable automatic cache headers associated with starting a session

Follow up to 7491b52. The 'private, must-revalidate' argument to
session_cache_limiter() does not match any expected values for the
function. This results in the PHP runtime treating it like the
documented empty string argument which completely disables the automatic
addition of cache related headers. Change the implementation to use the
empty string argument explicitly rather than continuing to rely on
the undocumented and potentially confusing existing behavior.

session_cache_limiter( '' ) is called unconditionally in
MediaWiki\Session\PHPSessionHandler::install(). This is safe now that it
is understood that we are disabling the setting of the automatic
headers.

Bug: T124510
Change-Id: I63164f8b7a408e370ff01dead42be27a0135dd35
includes/GlobalFunctions.php
includes/Setup.php
includes/context/RequestContext.php
includes/session/PHPSessionHandler.php
includes/session/SessionBackend.php