Deprecate Language::setCode as public method
authorFomafix <fomafix@googlemail.com>
Sat, 7 Jul 2018 09:53:04 +0000 (11:53 +0200)
committerKunal Mehta <legoktm@member.fsf.org>
Wed, 3 Oct 2018 06:48:53 +0000 (23:48 -0700)
commit50944a14108e15ffdf9bcaa0148a0e7790a5f2a9
tree3fc5bb3f08e575238a76c1ef741db04ea8515154
parentc9d843cbcef24202bd793e5bc4a870c831f59bf6
Deprecate Language::setCode as public method

setCode changes the language code for the Language object but it also
replaces the whole language codes for all Language objects.

> $lang = Language::factory( 'fr' )

> $lang2 = Language::factory( 'fr' )

> $lang->setCode( 'it' )

> print $lang2->getCode()
it
> $lang3 = Language::factory( 'fr' )

> print $lang3->getCode()
it

Better assign a new Language object.

Also add more tests for Language::equals.

Depends-On: I61439bac82021344c3f9a6056cccd937b3450af2
Depends-On: I2d9e551d6eb33f28f42aeaf48160eba21b83881f
Change-Id: I201b479f58e63c9c40fb8a3ec9575a551fb35235
RELEASE-NOTES-1.32
languages/Language.php
tests/phpunit/languages/LanguageTest.php