objectcache: Use variadic signature for makeKey()
authorTimo Tijhof <krinklemail@gmail.com>
Sat, 20 Jul 2019 16:49:06 +0000 (17:49 +0100)
committerBartosz Dziewoński <matma.rex@gmail.com>
Tue, 23 Jul 2019 18:44:06 +0000 (20:44 +0200)
commit460e68ab3bd1743c3a494fe45ad3b76c66020ce3
tree38862f62591d6b2b3f57ee912428342f9f2982da
parent902c7eef341ce5b7aae13113d2bb2369868e5b2a
objectcache: Use variadic signature for makeKey()

This should help fix the following issues that various repos
are getting from Phan as of late:

> Call with 5 arg(s) to \BagOStuff::makeKey() which only takes 2 arg(s)
> defined at ../../includes/libs/objectcache/BagOStuff.php:456
> <source="PhanParamTooMany"/>

Bug: T228563
Depends-On: I5cfba063821101325a5a7359e6b8ad71a0fb1b2f
Depends-On: Ifa5b96735376f2fbe3680799f960616ba8d357ff
Change-Id: Ic9df7f3ad7f356c7cbdfe1edfbe35821b931dda6
12 files changed:
includes/libs/objectcache/BagOStuff.php
includes/libs/objectcache/CachedBagOStuff.php
includes/libs/objectcache/IStoreKeyEncoder.php
includes/libs/objectcache/MediumSpecificBagOStuff.php
includes/libs/objectcache/MultiWriteBagOStuff.php
includes/libs/objectcache/ReplicatedBagOStuff.php
includes/libs/objectcache/WANObjectCache.php
tests/phpunit/includes/libs/objectcache/CachedBagOStuffTest.php
tests/phpunit/includes/libs/objectcache/MultiWriteBagOStuffTest.php
tests/phpunit/includes/libs/objectcache/WANObjectCacheTest.php
tests/phpunit/includes/watcheditem/WatchedItemStoreUnitTest.php
tests/phpunit/unit/includes/objectcache/RedisBagOStuffTest.php