SessionManager: Kill getPersistedSessionId()
authorBrad Jorsch <bjorsch@wikimedia.org>
Fri, 22 Jan 2016 19:47:33 +0000 (14:47 -0500)
committerBrad Jorsch <bjorsch@wikimedia.org>
Fri, 22 Jan 2016 19:47:33 +0000 (14:47 -0500)
commit43f904b51a746d7f71ea2ab9951c5c98d269765b
treeddcb4a52f28095593b532da3a4ebdea9682d2821
parent92ba9fa33df3dc6d76dbc7e09eddd3e7da3f3b75
SessionManager: Kill getPersistedSessionId()

It's not guaranteed that loadSessionFromStore() will succeed after
whatever alterations the SessionProvider might have made later in the
request.

So instead, let's make a new global object that stores the SessionId
of the persistent session that was loaded during Setup.php, if any. Then
we can check that when we need to know whether the session was
persisted.

Bug: T124468
Change-Id: I1e8e616c83b16aadd86b0a0a40826d40f6e8abe4
includes/Setup.php
includes/WebRequest.php
includes/session/SessionManager.php
includes/session/SessionManagerInterface.php
includes/specials/SpecialUserlogin.php
tests/phpunit/includes/session/SessionManagerTest.php