Move fatal PHP functions checks to initialization
authorChad Horohoe <chadh@wikimedia.org>
Tue, 14 Jun 2016 00:52:51 +0000 (17:52 -0700)
committerChad Horohoe <chadh@wikimedia.org>
Tue, 14 Jun 2016 19:50:39 +0000 (12:50 -0700)
commit41d1fa1c3aa9d6e9e0e5f0c5455b9092833e9012
tree7c817fce69c1c46d2930b6e3c7c3c41cb6282ce7
parent5ef01d99ed08527fc2616807bb1e7d43201c5f70
Move fatal PHP functions checks to initialization

The installer is far too late of a place to be checking if
a function does or doesn't exist if we require it for operation.
Functions can very easily (T137509) be called prior to ever
getting to the installer check page.

Also, an old installation could've gotten past the checks if
they ran update.php --skip-compat-checks. What a scary setting!

Instead, fail hard, fast and early along with PHP version checks.
All entry points are required to go through this.

While we're here, also remove the check for mbstring.func_overload
since we already would've failed at WebStart.php

Change-Id: Ib9727979af2a4741f3cd952d13a3bb350fad43e4
includes/PHPVersionCheck.php
includes/Setup.php
includes/installer/Installer.php
includes/installer/i18n/en.json
includes/installer/i18n/qqq.json