Preserve caller expectations for behaviour of sslVerifyHost
authorTim Starling <tstarling@wikimedia.org>
Thu, 28 Feb 2013 01:58:52 +0000 (17:58 -0800)
committerTim Starling <tstarling@wikimedia.org>
Thu, 28 Feb 2013 02:03:44 +0000 (18:03 -0800)
commit3d55a64b83851e13bbedd91b480d45ce22fd7914
tree23eef7684192663a07121d17745b7a791f533f1e
parent019ede87172494f1e2352926095b81d201723eee
Preserve caller expectations for behaviour of sslVerifyHost

(bug 42441) The previous patch unnecessarily broke backwards
compatibility in the Http::request() API, following cURL's broken
conventions for sslVerifyHost instead of the boolean interpretation
expected by all existing callers. This change reverts that one, and
fixes the bug in another way. See Ia6535f10.

Also don't bother wrapping the $this->sslVerifyHost access with isset()
since it's always set.

Change-Id: Ia4e1689249b6ac515b859ea2eca1dcff3e63098c
includes/HttpFunctions.php