Make the indexName functions more obviously laid out
authorReedy <reedy@wikimedia.org>
Thu, 30 Mar 2017 11:29:35 +0000 (12:29 +0100)
committerReedy <reedy@wikimedia.org>
Thu, 30 Mar 2017 11:29:35 +0000 (12:29 +0100)
commit3b000dc2a8743e71fd0b29a194ec80312d8654b3
treeac6ab9cb02d520f3bd492702e46441d5aa74d9fe
parent2c8f7978df47f338ee6e245e3efba6175ba425e9
Make the indexName functions more obviously laid out

Move Sqlites's indexName to Database to have no remapping by default.
This is because MSSQL and Postgresql both don't need remapping, it's
just MySQL that's the problem.

So move the one from Database into MysqlBase to only do the remappings
there.

Also fix up the comments to make them less vague, not mentioning tables
when the function has no table parameter passed, so hence, no context
as to which table said index is wanted to be used

Bug: T154872
Change-Id: I46c575771e6cb36176bcf6cd1a865b703db0275d
includes/libs/rdbms/database/Database.php
includes/libs/rdbms/database/DatabaseMysqlBase.php
includes/libs/rdbms/database/DatabaseSqlite.php