resourceloader: Clean up ResourceLoaderWikiModuleTest
authorTimo Tijhof <krinklemail@gmail.com>
Sat, 13 Jul 2019 18:27:33 +0000 (19:27 +0100)
committerRoan Kattouw <roan.kattouw@gmail.com>
Mon, 15 Jul 2019 22:38:46 +0000 (15:38 -0700)
commit397a3ee0bdf98abdba253e4a66949f83daa97172
treef1e5f7693db7ddf78102229dce0218021a0031c7
parent40a260b04f99458c1eb65127b0a8a7ec0aba79de
resourceloader: Clean up ResourceLoaderWikiModuleTest

* Remove redundant any() calls.
* Use willReturn() instead of will(returnValue()).
* Use yield for providers and add missing test case descriptions.
* Use createMock() instead of wfGetDB() where the DB isn't needed.

* For provideIsKnownEmpty, re-order the cases and add a few extra
  cases, and document why they behave the way they do.

Change-Id: Iba42325a55bb3dfc50a8d2af46e1ddba8dda885a
tests/phpunit/includes/resourceloader/ResourceLoaderWikiModuleTest.php