rdbms: Roll back empty implicit transaction on error
authorBrad Jorsch <bjorsch@wikimedia.org>
Thu, 5 Apr 2018 18:16:03 +0000 (14:16 -0400)
committerBrad Jorsch <bjorsch@wikimedia.org>
Thu, 5 Apr 2018 18:45:18 +0000 (14:45 -0400)
commit395462b7d5e1384f8c8c8df4c1ef7ec6e9fdc573
treedd0575d0fa981cb0f67f6af7ddd472238b815a74
parent5211d2ab6839b47df5ac5278844c6d068e4640d9
rdbms: Roll back empty implicit transaction on error

If we're not going to set trxStatus to an error state in this case, we
need to issue a rollback to be sure the database (i.e. PostgreSQL) isn't
still in an error state too.

Bug: T189999
Change-Id: Id6e203b216fff937b6a97d779b36c278e3366409
includes/libs/rdbms/database/Database.php
tests/phpunit/includes/db/DatabaseTestHelper.php
tests/phpunit/includes/libs/rdbms/database/DatabaseSQLTest.php