RCFilters: Prevent duplicate filter names
authorMatthew Flaschen <mflaschen@wikimedia.org>
Thu, 16 Mar 2017 04:06:02 +0000 (00:06 -0400)
committerCatrope <roan@wikimedia.org>
Thu, 16 Mar 2017 07:19:40 +0000 (07:19 +0000)
commit2f6f69e834c1fa665d3552ad415d4315e6cc41a3
tree27380ff9fa23c03b4dbae155d6b656a96f70dcfc
parentd233035cb445953fff3478d79f8c111c911cd4ac
RCFilters: Prevent duplicate filter names

Explicitly block two filters in the same group from having the same
name.

Before, it would be left to registerFilter, which would just cause
the second one to win.

Also, avoid a getFilter warning when the filter does not exist.
Do the same for getFilterGroup on ChangesListSpecialPage

Finally, a minor related doc fix.

Change-Id: I6b3880a5c7cc381c169bbd969cd4814559b49c91
docs/hooks.txt
includes/changes/ChangesListFilter.php
includes/changes/ChangesListFilterGroup.php
includes/specialpage/ChangesListSpecialPage.php
tests/phpunit/includes/changes/ChangesListFilterGroupTest.php
tests/phpunit/includes/changes/ChangesListFilterTest.php