Storage: SqlBlobStore no longer needs Language object
authorTimo Tijhof <krinklemail@gmail.com>
Tue, 1 Oct 2019 16:20:45 +0000 (17:20 +0100)
committerReedy <reedy@wikimedia.org>
Wed, 6 Nov 2019 16:58:06 +0000 (16:58 +0000)
commit2dfeefe44ec9f2ee975ff4cf5a6c349729c8c80f
treebea2307ddf17d601bf2914c406e05152a77181f7
parent407d50c860fa5ff73cf342ca74b1a321e628eab5
Storage: SqlBlobStore no longer needs Language object

Constructing a Language object in order to initialize the
BlobStoreFactory service causes a circular dependency
(see T231866).

SqlBlobStore was using the Language object to all iconv.
But nothing language specific is done in Language::iconv,
so we can just inline the call.

Bug: T231866
Change-Id: I90c25decbcff10ea762a2c7474a12fd2041b3abc
includes/ServiceWiring.php
includes/Storage/BlobStoreFactory.php
includes/Storage/SqlBlobStore.php
tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php
tests/phpunit/includes/RevisionTest.php
tests/phpunit/includes/Storage/SqlBlobStoreTest.php