AuthManagerTest: Fix for PHPUnit 6
authorBrad Jorsch <bjorsch@wikimedia.org>
Thu, 12 Apr 2018 17:25:19 +0000 (13:25 -0400)
committerBrad Jorsch <bjorsch@wikimedia.org>
Thu, 12 Apr 2018 17:29:00 +0000 (13:29 -0400)
commit23596834bf86f03be194d77c040df0140e438c65
treef20532e2321f5f7709f6dc03cf0261f0d9efef77
parent71653df1c365ec4092ca3390f1857d5e8e435b6e
AuthManagerTest: Fix for PHPUnit 6

PHPUnit 6 apparently needs methods explicitly declared as mockable in
some cases where PHPUnit 4 didn't, specifically
'providerAllowsAuthenticationDataChange' in testGetAuthenticationRequests.

That also means we need to remove the (fortunately unnecessary) forcing
of the mocked class name in there, or else it reuses the generic
configuration created under that name for earlier tests.

For good measure, let's also remove the mocked class name forcing from
several other places where it isn't needed (but was presumably
copy-pasted from the places where it was).

Change-Id: If12ed836c7e47797f20deb0bdaa3ea852a921069
tests/phpunit/includes/auth/AuthManagerTest.php