Pass '' instead of false for the $conds parameter in select calls.
authordaniel <daniel.kinzler@wikimedia.de>
Tue, 27 Feb 2018 18:37:26 +0000 (19:37 +0100)
committerKrinkle <krinklemail@gmail.com>
Fri, 2 Mar 2018 02:32:54 +0000 (02:32 +0000)
commit218e8311d578edfa04493cfde54f1850cd4cd6e3
tree526807ec07d6ae63ed2afa8603aa5bd5228926dc
parentf4ec592330517bc80e2ee351d0385e752f16e3fb
Pass '' instead of false for the $conds parameter in select calls.

Per documentation on IDatabase, $conds must be a string or an array.
Passing false for conds is confusing, since it's unclear whether this
should match everything or nothing.

Bug: T188314
Change-Id: I8be1ac4cbdaafc41aadc2a658be8a99b754b0268
26 files changed:
includes/installer/DatabaseUpdater.php
includes/specials/SpecialRecentchanges.php
includes/specials/pagers/ContribsPager.php
includes/specials/pagers/NewFilesPager.php
maintenance/archives/upgradeLogging.php
maintenance/clearInterwikiCache.php
maintenance/migrateActors.php
maintenance/populateBacklinkNamespace.php
maintenance/populateFilearchiveSha1.php
maintenance/populateIpChanges.php
maintenance/populateLogSearch.php
maintenance/populateLogUsertext.php
maintenance/populateParentId.php
maintenance/populateRecentChangesSource.php
maintenance/populateRevisionLength.php
maintenance/populateRevisionSha1.php
maintenance/rebuildFileCache.php
maintenance/refreshLinks.php
maintenance/storage/checkStorage.php
maintenance/storage/fixT22757.php
maintenance/storage/moveToExternal.php
maintenance/storage/orphanStats.php
maintenance/storage/resolveStubs.php
maintenance/storage/storageTypeStats.php
maintenance/storage/trackBlobs.php
maintenance/updateRestrictions.php