Revert and fix "Revert "Modify -—with-extensions to throw extension dependency errors""
authorBrad Jorsch <bjorsch@wikimedia.org>
Thu, 5 Sep 2019 14:34:36 +0000 (10:34 -0400)
committerBrad Jorsch <bjorsch@wikimedia.org>
Thu, 5 Sep 2019 17:16:40 +0000 (13:16 -0400)
commit0aec1401e59f0c386729792515995b319d6480e0
tree5da3808cacf6ae7b5afad81fdbe9de55578ed887
parent62ef2c1e563ba5b60aac3fd5f0967ca381def0d7
Revert and fix "Revert "Modify -—with-extensions to throw extension dependency errors""

This reverts commit cc7ec36a577161bba06159abd15efddc8a4f745d.

It makes the following changes from the original patch:
* findExtensions() will not consider config-extension-not-found as an
  error.
* Fixed a bug where extension info wouldn't actually be returned by
  findExtensions().
* When an extension's dependency doesn't exist, wrap the
  config-extension-not-found error in config-extension-dependency.
  This makes it more clear, and prevents the error from being ignored
  per the first bullet.
* maintenance/install.php will use ->text() rather than ->parse()
  when printing thrown errors.
* Change the stuff done to make phan happy.

Bug: T225512
Change-Id: I7d29700e8b7e91841556847d669b350cbd306fe6
includes/installer/CliInstaller.php
includes/installer/Installer.php
includes/installer/WebInstallerOptions.php
maintenance/install.php