Mostly drop old comment schemas
authorBrad Jorsch <bjorsch@wikimedia.org>
Fri, 4 Jan 2019 18:55:11 +0000 (13:55 -0500)
committerTim Starling <tstarling@wikimedia.org>
Thu, 7 Feb 2019 05:59:27 +0000 (16:59 +1100)
commit0abb9338f870824e258a7a138ad07efbaa6b3894
treec760e283bae14f5576a1b938ab8b1b42937bb265
parent262fd585d0e6d7e821461cc7f191c8d2f5644c4c
Mostly drop old comment schemas

This removes most of the pre-CommentStore text columns, and the
$wgCommentTableSchemaMigrationStage setting that used to determine
whether the columns were used.

rev_comment remains in the code, as on Wikimedia wikis the revision
table is too large to alter at this time. A future change will combine
that with the removal of rev_user_text, rev_content_model, and
rev_content_format (and the addition of rev_comment_id and rev_actor).

CommentStore's constructor continues to take a $stage parameter, and
continues to have the logic for handling it, for the benefit of
extensions that might need their own migration process.

Bug: T166733
Change-Id: I1479c73774e01ead1490adf6128f820c09bce9d4
53 files changed:
RELEASE-NOTES-1.33
includes/CommentStore.php
includes/DefaultSettings.php
includes/EditPage.php
includes/FileDeleteForm.php
includes/ProtectionForm.php
includes/ServiceWiring.php
includes/actions/McrUndoAction.php
includes/filerepo/file/LocalFile.php
includes/installer/DatabaseUpdater.php
includes/installer/MssqlUpdater.php
includes/installer/MysqlUpdater.php
includes/installer/OracleUpdater.php
includes/installer/PostgresUpdater.php
includes/installer/SqliteUpdater.php
includes/page/Article.php
includes/page/WikiPage.php
includes/resourceloader/ResourceLoaderStartUpModule.php
includes/specials/SpecialBlock.php
includes/specials/SpecialEditTags.php
includes/specials/SpecialMovepage.php
includes/specials/SpecialRevisiondelete.php
includes/specials/SpecialUndelete.php
includes/specials/SpecialUserrights.php
maintenance/archives/patch-drop-comment-fields.sql [new file with mode: 0644]
maintenance/migrateComments.php
maintenance/mssql/archives/patch-drop-comment-fields.sql [new file with mode: 0644]
maintenance/mssql/tables.sql
maintenance/oracle/archives/patch-drop-comment-fields.sql [new file with mode: 0644]
maintenance/oracle/tables.sql
maintenance/postgres/tables.sql
maintenance/sqlite/archives/patch-archive-drop-ar_comment.sql [new file with mode: 0644]
maintenance/sqlite/archives/patch-filearchive-drop-fa_description.sql [new file with mode: 0644]
maintenance/sqlite/archives/patch-image-drop-img_description.sql [new file with mode: 0644]
maintenance/sqlite/archives/patch-ipblocks-drop-ipb_reason.sql [new file with mode: 0644]
maintenance/sqlite/archives/patch-logging-drop-log_comment.sql [new file with mode: 0644]
maintenance/sqlite/archives/patch-oldimage-drop-oi_description.sql [new file with mode: 0644]
maintenance/sqlite/archives/patch-protected_titles-drop-pt_reason.sql [new file with mode: 0644]
maintenance/sqlite/archives/patch-recentchanges-drop-rc_comment.sql [new file with mode: 0644]
maintenance/tables.sql
tests/parser/ParserTestRunner.php
tests/phpunit/includes/ActorMigrationTest.php
tests/phpunit/includes/CommentStoreTest.php
tests/phpunit/includes/CommentStoreTest.sql [new file with mode: 0644]
tests/phpunit/includes/Revision/RevisionQueryInfoTest.php
tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php
tests/phpunit/includes/RevisionDbTestBase.php
tests/phpunit/includes/RevisionTest.php
tests/phpunit/includes/deferred/LinksUpdateTest.php
tests/phpunit/includes/logging/DatabaseLogEntryTest.php
tests/phpunit/includes/page/PageArchiveTestBase.php
tests/phpunit/includes/page/WikiPageDbTestBase.php
tests/phpunit/maintenance/deleteAutoPatrolLogsTest.php