Default $wgActorTableSchemaMigrationStage to READ_NEW
authorBrad Jorsch <bjorsch@wikimedia.org>
Wed, 3 Apr 2019 17:11:46 +0000 (13:11 -0400)
committerBrad Jorsch <bjorsch@wikimedia.org>
Tue, 9 Apr 2019 17:50:41 +0000 (13:50 -0400)
commit0301c8e03aad7b81094c3d31c4f5e4e293d9db5f
treeda7bfa287bcaac5d2b303ddf3f8bfa53e0d5525e
parent31aeedb98a9f6afcbef2262abdda39cda9ea1090
Default $wgActorTableSchemaMigrationStage to READ_NEW

Probably good to start testing this in CI sometime soon.

The unit tests being changed here are:
* Hacky importing of a revision in MessageCacheTest, changed to use an
  interwiki username.
* WikiPageDbTestBase will get null rather than 0 for ar_user.
* DumpTestCase was using a custom IP $wgUser when creating its test
  revisions, which was winding up referring to an actor_id that had been
  deleted from the database. Fixed by having it use a registered user
  instead.

Also this has MediaWikiTestCase reset the $wgUser User object when the
actor table is truncated, as various tests were otherwise failing because
it was caching a later-deleted actor ID for User:127.0.0.1.

Bug: T188327
Change-Id: Ic483d0fda931810ac639b9de1cc5e5a4ef8161cc
Depends-On: I1bd0288cc132627d75b4001219522ec5e952eda7
RELEASE-NOTES-1.33
includes/DefaultSettings.php
tests/phpunit/MediaWikiTestCase.php
tests/phpunit/includes/cache/MessageCacheTest.php
tests/phpunit/includes/page/WikiPageDbTestBase.php
tests/phpunit/maintenance/DumpAsserter.php
tests/phpunit/maintenance/DumpTestCase.php
tests/phpunit/maintenance/backupTextPassTest.php