X-Git-Url: https://git.heureux-cyclage.org/?p=lhc%2Fweb%2Fwiklou.git;a=blobdiff_plain;f=tests%2Fphpunit%2Fincludes%2Flibs%2Fobjectcache%2FMultiWriteBagOStuffTest.php;h=9f88474e7b2cbb0dd5ab6b6a4298468853c21084;hp=0376803f41bfd19eb862f650d3a6eec5715457d6;hb=a3cd158d8433e41cbeb299f0e268dfef363b2afd;hpb=3110946330d98b7d61ab5b1899c09db723a152a3

diff --git a/tests/phpunit/includes/libs/objectcache/MultiWriteBagOStuffTest.php b/tests/phpunit/includes/libs/objectcache/MultiWriteBagOStuffTest.php
index 0376803f41..9f88474e7b 100644
--- a/tests/phpunit/includes/libs/objectcache/MultiWriteBagOStuffTest.php
+++ b/tests/phpunit/includes/libs/objectcache/MultiWriteBagOStuffTest.php
@@ -28,8 +28,8 @@ class MultiWriteBagOStuffTest extends MediaWikiTestCase {
 	 * @covers MultiWriteBagOStuff::doWrite
 	 */
 	public function testSetImmediate() {
-		$key = wfRandomString();
-		$value = wfRandomString();
+		$key = 'key';
+		$value = 'value';
 		$this->cache->set( $key, $value );
 
 		// Set in tier 1
@@ -42,8 +42,8 @@ class MultiWriteBagOStuffTest extends MediaWikiTestCase {
 	 * @covers MultiWriteBagOStuff
 	 */
 	public function testSyncMerge() {
-		$key = wfRandomString();
-		$value = wfRandomString();
+		$key = 'keyA';
+		$value = 'value';
 		$func = function () use ( $value ) {
 			return $value;
 		};
@@ -56,14 +56,14 @@ class MultiWriteBagOStuffTest extends MediaWikiTestCase {
 		// Set in tier 1
 		$this->assertEquals( $value, $this->cache1->get( $key ), 'Written to tier 1' );
 		// Not yet set in tier 2
-		$this->assertEquals( false, $this->cache2->get( $key ), 'Not written to tier 2' );
+		$this->assertFalse( $this->cache2->get( $key ), 'Not written to tier 2' );
 
 		$dbw->commit();
 
 		// Set in tier 2
 		$this->assertEquals( $value, $this->cache2->get( $key ), 'Written to tier 2' );
 
-		$key = wfRandomString();
+		$key = 'keyB';
 
 		$dbw->begin();
 		$this->cache->merge( $key, $func, 0, 1, BagOStuff::WRITE_SYNC );
@@ -80,8 +80,8 @@ class MultiWriteBagOStuffTest extends MediaWikiTestCase {
 	 * @covers MultiWriteBagOStuff::set
 	 */
 	public function testSetDelayed() {
-		$key = wfRandomString();
-		$value = (object)[ 'v' => wfRandomString() ];
+		$key = 'key';
+		$value = (object)[ 'v' => 'saved value' ];
 		$expectValue = clone $value;
 
 		// XXX: DeferredUpdates bound to transactions in CLI mode
@@ -90,12 +90,12 @@ class MultiWriteBagOStuffTest extends MediaWikiTestCase {
 		$this->cache->set( $key, $value );
 
 		// Test that later changes to $value don't affect the saved value (e.g. T168040)
-		$value->v = 'bogus';
+		$value->v = 'other value';
 
 		// Set in tier 1
 		$this->assertEquals( $expectValue, $this->cache1->get( $key ), 'Written to tier 1' );
 		// Not yet set in tier 2
-		$this->assertEquals( false, $this->cache2->get( $key ), 'Not written to tier 2' );
+		$this->assertFalse( $this->cache2->get( $key ), 'Not written to tier 2' );
 
 		$dbw->commit();